Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspectj-ext 4.2.1 and AGP 4 hangs for multi-module app when using includeJar on feature module #126

Closed
davidwong opened this issue Jul 31, 2020 · 1 comment

Comments

@davidwong
Copy link

When using aspectj-ext plugin with AGP 4.0.1 (also 4.0) in a app with multiple modules, using includeJar for a dependency module hangs the build process at app at app:dexBuilderDebug. It used to work OK with AGP 3.x and the older version of the plugin.

Wrote a demo app to show the problem:
AspectJTest.zip

The app has the app module with the aspect, and a base module that the app module depends on.

  • Using the normal aspectj plugin in the app build.gradle (apply plugin: 'com.archinamon.aspectj') has a successful build and works for the app module. However the pointcut can't find the code in the base module to advice.
  • Switch to the aspectj-ext plugin and use includeJar for the base module, the aspectj transform stage works according to ajc-transform.log. However the build process seems to hang at the app:dexBuilderDebug stage, it seems to just keep running (I gave up after 20 minutes).

Was wondering if anyone has successfully used the aspectj plugin successfully for app with feature modules.

@davidwong
Copy link
Author

Just closing this issue as AGP and plugin versions have moved on. Don't know if this has been fixed, but getting around it by using the standard version of the plugin in each module instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant