Refactoring and update modules : Right click Contextual menu added #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al menu items Removed any references to module menu. Added a buttonbarbutton mangement in TNModules Added a contextual menuItem management in TNModules
Added also Sender detection
…when item are removed from Menu.
Added also Sender detection. XIB : Change Popover to transients.
(we can't use the model defined in TNModule as this controller is not a module).
Related to adapt selection on right click.
…tonBar refactoring
+ use CPImageInBundle, @{@"key":object} ...
…tonBar refactoring Also use CPImageInBundle when necessary
…onBar refactoring
…onBar refactoring + FIX the filtered view with searchfield
…ar refactoring + Use CPImageInBundle
…oring Contextual menu only to apply role on one or more selected users.
XIB : Also fix a performclick action on textfield which send twice the scheduling action when using enter key on popover.
Replaced the warning message when multiple items are not allowed, by disabling the controls (thanks to permissionControler :) )
XIB : Set multiple selection flag on tableCharatersDevices. Implement the multiple deletion by the way for Charactres devices.
…refactoring + autocompletion with current domain when adding user + Handle the delete key on row + Fix a bug in TNModuleController when ToolBar CiB is called before module inititialization
…h @{@"key":object}
Fixed by #1902 in Cappuccino.
| @@ -98,10 +98,10 @@ var TNArchipelTypePermissions = @"archipel:permissions", | |||
| - (void)awakeFromCib | |||
| { | |||
| _currentUserPermissions = [CPArray array]; | |||
| _defaultAvatar = [[CPImage alloc] initWithContentsOfFile:[[CPBundle mainBundle] pathForResource:@"user-unknown.png"]]; | |||
| _defaultAvatar = CPImageInBundle(@"user-unknown.png", nil [CPBundle mainBundle]); | |||
|
When we right click on table void to add something, the popover should open on the plus button, (or related creation button), not in the tableview |
Pass the capplint test on all j files, strict mode only warn on consecutive var declarations.
|
Ready for review should be ok for now, just need the capp fix :) |
|
Good. Merged. Thanks! |
|
great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On all modules :
In all the code : (except libraries)
Some UI improvements :
This PR need some cappuccino fixes :
highlight status is not reseted Instantiated CPMenuItem highlight status is not well removed when using [menu removeAllItems] cappuccino/cappuccino#1899The ghosting menu issue : Ghost CPMenu when right clicking multiple times cappuccino/cappuccino#1887