Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs, LTTP: clarify not using qusb and remove redundancies #1373

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Hopefully reduce people trying and failing to use QUsb2SNES

How was this tested?

I read it.

@Joethepic
Copy link
Contributor

This might also want to be applied to smz3 and possibly other snes guides

Copy link
Contributor

@SoldierofOrder SoldierofOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions! Looks good to me otherwise. :)

worlds/alttp/docs/multiworld_en.md Outdated Show resolved Hide resolved
worlds/alttp/docs/multiworld_en.md Outdated Show resolved Hide resolved
worlds/alttp/docs/multiworld_en.md Outdated Show resolved Hide resolved
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label May 31, 2023
@Bicoloursnake
Copy link
Contributor

Bicoloursnake commented Jun 18, 2023

Following @black-sliver putting this up to community review, I went and looked through this. The update looks good. Soldier's recommendations also look good with the one caveat I noted above.

@PoryGone
Copy link
Collaborator

This looks good to me, language-wise.

Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're gonna edit this doc, we may also want to update the sections that reference which lua to load.

See:

  • ##### BizHawk 3. Drag+drop the 'Connector.lua' file that you downloaded above onto the main EmuHawk window.
    • There is no Connector.lua file anymore.
  • ##### snes9x-rr 5. Select the connector lua file included with your client
    • What connector lua file? 🤷
    • image

@alwaysintreble
Copy link
Collaborator Author

If we're gonna edit this doc, we may also want to update the sections that reference which lua to load.

See:

  • ##### BizHawk 3. Drag+drop the 'Connector.lua' file that you downloaded above onto the main EmuHawk window.

    • There is no Connector.lua file anymore.
  • ##### snes9x-rr 5. Select the connector lua file included with your client

    • What connector lua file? 🤷
    • image

You're looking in the wrong directory. lttp still uses the SNI connector, that hasn't changed. /SNI/lua/ which the guide references.

Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did absolutely read it wrong. I shouldn't review after a certain hour. LGTM

@ThePhar ThePhar merged commit 07e3fbe into ArchipelagoMW:main Jun 28, 2023
6 checks passed
@alwaysintreble alwaysintreble deleted the lttp_guide branch July 19, 2023 21:46
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…goMW#1373)

* clarify not using qusb and remove redundancies

* SNES mini note

* review suggestions

* remove remaining repetitive text

---------

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…goMW#1373)

* clarify not using qusb and remove redundancies

* SNES mini note

* review suggestions

* remove remaining repetitive text

---------

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants