Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2: Rebalance item classes #1512

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

Ziktofel
Copy link
Collaborator

@Ziktofel Ziktofel commented Mar 7, 2023

Sets Advanced Medic Facilities (Medic) to filler as:
This item is never useful to get out of BK and is never part of logic

Sets these items for useful:

  • Fire-Suppression System (Building)
  • Cellular Reactor
  • Regenerative Bio-Steel
    As these items are more useful than others in filler class

This item is never useful to get out of BK and is never part of logic
@Magnemania
Copy link
Contributor

@TheCondor07 You are the maintainer for this world, so we'd like you to approve this.

Some context for anyone reading this PR:

StarCraft II has no natural filler items whatsoever; every item in the game has some situational purpose and is nonreplenishable. TheCondor created three filler items specifically for the randomizer (+15 Starting Minerals/Vespene and +2 Starting Supply), but there's only room for about 5? of them in the vanilla location pool.

To compensate for this skewed ratio compared to other AP games, less useful items are classified as filler; this is comparable to how the SM AP randomizer classifies many of its Missiles/Super Missiles/Power Bombs as filler despite those items being valuable in the game and potentially even affecting progression. It makes it possible for a StarCraft player to exclude locations, and in a multiworld context, it ensures that excluded locations across the multiworld won't have a bias towards non-SC2 players (sucking up all of the rupees, missiles, and emblems that would let the players in those worlds finish their games faster).

It is less important to classify items as filler now that SC2 settings allow the player to customize their item and location pool; they have a limited ability to remove checks that they don't want to complete from the game entirely, and can remove items that would be replaced with filler items if the location pool is large enough. However, in the specific case of Advanced Medic Facilities, I believe it does deserve the filler designation for these reasons:

  • Advanced Medic Facilities allows players to build Medics without a Tech Lab. Of the infantry units that Medics can support, only 1/6 does not also require a tech lab to be built, so if the player has not received that particular item they're going to be building Tech Labs anyways.
  • The Tech Reactor item almost eclipses Advanced Medic Facilities, as it removes the Tech Lab from the game. There is still one use case for Advanced Medic Facilities with both items (building Medics from a Barracks with no add-on at all) but this is a rare one, as most players will immediately build a Tech Reactor at the very start of the mission in order to double production speed.
  • There are quite a few other unique items currently classified as filler that are far more universally useful than Advanced Medic Facilities, such as Cellular Reactor and Regenerative Bio-Steel (both of which were placed as major rewards in the vanilla game).

I approve of this PR, but Condor should see it. I also think it might be better to make this a general filler/useful reclassification PR, these items 'ought to be classified as Useful for their tendency to always be useful in AP regardless of which other items have been received:

  • Fire-Suppression System (Building)
  • Cellular Reactor
  • Regenerative Bio-Steel

@Ziktofel Ziktofel changed the title SC2: Set item Advanced Medic Facilities (Medic) to filler class SC2: Rebalance item classes Mar 9, 2023
@Ziktofel
Copy link
Collaborator Author

Ziktofel commented Mar 9, 2023

Added these items, tested by generating a game. Title and description updated

Copy link
Contributor

@Magnemania Magnemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support these changes. Still need Condor's approval.

@Berserker66 Berserker66 merged commit e49ffc6 into ArchipelagoMW:main Apr 10, 2023
@Ziktofel Ziktofel deleted the patch-1 branch April 11, 2023 11:44
kindasneaki pushed a commit to kindasneaki/Archipelago that referenced this pull request Jun 28, 2023
It's been a month, if Condor disapproves this can be reverted.
I don't really know what to do about the SC2WOL situation going forward.
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
It's been a month, if Condor disapproves this can be reverted.
I don't really know what to do about the SC2WOL situation going forward.
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
It's been a month, if Condor disapproves this can be reverted.
I don't really know what to do about the SC2WOL situation going forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants