Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: Align multitracker status column to the left #1645

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

freyacodes
Copy link
Contributor

@freyacodes freyacodes commented Apr 1, 2023

What is this fixing or adding?

Aligns the status column head in the multitracker to the left, to align with the column's content. Consistent with the rest of the design.

How was this tested?

Accessing the multitracker

If this makes graphical changes, please attach screenshots.

Before:
image

Now:
image

@LegendaryLinux
Copy link
Member

Nearly all of the content in the MultiTracker is centered. Can we just center this column's data instead?

@freyacodes
Copy link
Contributor Author

Half of the other columns in the generic table are aligned left
image

Keeping the content centered could work, but I still think aligning it left makes more sense since it is not numeral content

@LegendaryLinux
Copy link
Member

LegendaryLinux commented Apr 5, 2023

Oh, I see what you mean. Okay, alternate solution since I think columns containing primarily text should be left-aligned.

Move the Status column after the Game column, and keep everything in the Status column left-aligned. That should look good and still make sense as you read the table.

@LegendaryLinux LegendaryLinux self-requested a review April 5, 2023 23:38
@LegendaryLinux LegendaryLinux self-assigned this Apr 5, 2023
@freyacodes
Copy link
Contributor Author

That's an excellent idea. I'll implement that when I get the time

@freyacodes freyacodes marked this pull request as draft April 6, 2023 17:25
@freyacodes
Copy link
Contributor Author

Finally got around to doing this

image

I made sure to place the column before any custom multitracker columns
image

@freyacodes freyacodes marked this pull request as ready for review May 30, 2023 19:36
@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels May 31, 2023
@LegendaryLinux LegendaryLinux merged commit d51e0ec into ArchipelagoMW:main Jun 27, 2023
6 checks passed
@freyacodes freyacodes deleted the status-column-alignment branch June 27, 2023 21:37
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…1645)

* Align multitracker status column to the left

* Move 'Status' column to after 'Game' column
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…1645)

* Align multitracker status column to the left

* Move 'Status' column to after 'Game' column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants