Core: Attribute per slot random directly to the World and discourage using MultiWorld's random #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what it's worth, I like this interface better. But I don't have the expertise to comment on functionality side effects. |
|
|
# Conflicts: # worlds/messenger/__init__.py
ThePhar
added
is: documentation
NewSoupVi
approved these changes
Jun 20, 2023
# Conflicts: # worlds/messenger/__init__.py
# Conflicts: # worlds/messenger/__init__.py
ThePhar
approved these changes
Jul 2, 2023
Merged
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…using MultiWorld's random (ArchipelagoMW#1649) * add a random object to the World * use it in The Messenger * the worlds don't exist until the end of set options * set seed in lttp tests * use world.random for shop shuffle
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…using MultiWorld's random (ArchipelagoMW#1649) * add a random object to the World * use it in The Messenger * the worlds don't exist until the end of set options * set seed in lttp tests * use world.random for shop shuffle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Using the multiworld's random tends to give problems with multithreading etc. but
per_slot_randomis awkard to use. This adds the random object directly to AutoWorld for worlds to use. Next steps are to fully deprecate and remove multiworld random usage, thenper_slot_random. Needs a decent solution forstage_callables and if the multiworld needs to do any randomization during output/multidata stages. Sincestage_callablegets called through a set, using the multiworld random is already incorrect for those.The biggest problem with this currently is that the worlds don't exist until after options get set... Wondering if as part of this PR those should be set up in a separate stage, the seed should be set after, or if we just leave it how I have it currently set.
How was this tested?
Added it to The Messenger and ran some generations.