Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noita: implement new game #1676

Merged
merged 146 commits into from
Apr 20, 2023
Merged

Noita: implement new game #1676

merged 146 commits into from
Apr 20, 2023

Conversation

heinermann
Copy link
Collaborator

@heinermann heinermann commented Apr 7, 2023

What is this fixing or adding?

Adding Noita (PC game) to Archipelago.

How was this tested?

Manual verification and existing unit tests. No automated testing was added. 2 beta tests.

Additional Notes

  • Old PR here.
  • Will the character ä cause any problems for other games?
  • Went for a slim __init__.py.
  • Please point out if anything is unclear at first glance.
  • Open to test suggestions since I haven't familiarized myself with the test framework yet.

DaftBrit and others added 30 commits August 31, 2022 21:14
…data version set to 1, auto_forfeit set to false
Complete rewrite, regions, and shop items support
Modified victory condition
Tested, and it functioned properly
Items, locations, and options additions
Limit the generation of chest locations
In the future, I want to also include West and East ones as well, but that's for later, when we figure out the best way to implement that.
Rules to prevent gold/potions from appearing in shops, and restrict w…
In the future, I want to also include West and East ones as well, but that's for later, when we figure out the best way to implement that.
Updated locations list to include bosses and orbs, and their regions.
Refactored the locations list to better compare them with options to determine which locations to use.

Submitting this as a draft because I haven't tested this yet. Just want to get the refactor up mostly.
@ScipioWright
Copy link
Collaborator

This is ready for final review now. We have made the changes we wanted to make, and believe this is in a good place.

@heinermann heinermann requested a review from ThePhar April 18, 2023 20:54
Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple tweaks to be made.

worlds/noita/__init__.py Show resolved Hide resolved
worlds/noita/__init__.py Outdated Show resolved Hide resolved
worlds/noita/__init__.py Outdated Show resolved Hide resolved
@ThePhar ThePhar merged commit 4dc9347 into ArchipelagoMW:main Apr 20, 2023
10 checks passed
kindasneaki pushed a commit to kindasneaki/Archipelago that referenced this pull request Jun 28, 2023
* Noita: implement new game (ArchipelagoMW#1676)

---------

Co-authored-by: DaftBrit <87314354+DaftBrit@users.noreply.github.com>
Co-authored-by: l.kelsall@b4rn.org.uk <l.kelsall@b4rn.org.uk>
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Co-authored-by: Scipio Wright <lightdemonjoe4@gmail.com>
Co-authored-by: Zach Parks <zach@alliware.com>
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
* Noita: implement new game (ArchipelagoMW#1676)

---------

Co-authored-by: DaftBrit <87314354+DaftBrit@users.noreply.github.com>
Co-authored-by: l.kelsall@b4rn.org.uk <l.kelsall@b4rn.org.uk>
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Co-authored-by: Scipio Wright <lightdemonjoe4@gmail.com>
Co-authored-by: Zach Parks <zach@alliware.com>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
* Noita: implement new game (ArchipelagoMW#1676)

---------

Co-authored-by: DaftBrit <87314354+DaftBrit@users.noreply.github.com>
Co-authored-by: l.kelsall@b4rn.org.uk <l.kelsall@b4rn.org.uk>
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Co-authored-by: Scipio Wright <lightdemonjoe4@gmail.com>
Co-authored-by: Zach Parks <zach@alliware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: new game Pull requests for implementing new games into Archipelago.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants