-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noita: implement new game #1676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data version set to 1, auto_forfeit set to false
Added deathlink
Adding perks to pool
Complete rewrite, regions, and shop items support
Modified victory condition Tested, and it functioned properly
Items, locations, and options additions
Limit the generation of chest locations
In the future, I want to also include West and East ones as well, but that's for later, when we figure out the best way to implement that.
Rules to prevent gold/potions from appearing in shops, and restrict w…
In the future, I want to also include West and East ones as well, but that's for later, when we figure out the best way to implement that.
Updated locations list to include bosses and orbs, and their regions.
Refactored the locations list to better compare them with options to determine which locations to use. Submitting this as a draft because I haven't tested this yet. Just want to get the refactor up mostly.
Added the Ocarina (to be preloaded with mountain teleport), renamed the perks, reordered a little
Coincidentally, the hell orb is now at 110666
Location & Item ID squish
Removed Collapsed Mines locations
Changed region pathing due to early game difficulty spikes
Forgot to actually link the overgrown to the jungle
This is ready for final review now. We have made the changes we wanted to make, and believe this is in a good place. |
ThePhar
requested changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a couple tweaks to be made.
Revisions per Phar's comments
ThePhar
approved these changes
Apr 20, 2023
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
* Noita: implement new game (ArchipelagoMW#1676) --------- Co-authored-by: DaftBrit <87314354+DaftBrit@users.noreply.github.com> Co-authored-by: l.kelsall@b4rn.org.uk <l.kelsall@b4rn.org.uk> Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com> Co-authored-by: Scipio Wright <scipiowright@gmail.com> Co-authored-by: Scipio Wright <lightdemonjoe4@gmail.com> Co-authored-by: Zach Parks <zach@alliware.com>
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* Noita: implement new game (ArchipelagoMW#1676) --------- Co-authored-by: DaftBrit <87314354+DaftBrit@users.noreply.github.com> Co-authored-by: l.kelsall@b4rn.org.uk <l.kelsall@b4rn.org.uk> Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com> Co-authored-by: Scipio Wright <scipiowright@gmail.com> Co-authored-by: Scipio Wright <lightdemonjoe4@gmail.com> Co-authored-by: Zach Parks <zach@alliware.com>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* Noita: implement new game (ArchipelagoMW#1676) --------- Co-authored-by: DaftBrit <87314354+DaftBrit@users.noreply.github.com> Co-authored-by: l.kelsall@b4rn.org.uk <l.kelsall@b4rn.org.uk> Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com> Co-authored-by: Scipio Wright <scipiowright@gmail.com> Co-authored-by: Scipio Wright <lightdemonjoe4@gmail.com> Co-authored-by: Zach Parks <zach@alliware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adding Noita (PC game) to Archipelago.
How was this tested?
Manual verification and existing unit tests. No automated testing was added. 2 beta tests.
Additional Notes
__init__.py
.