Pokemon Emerald: Implement New Game #1813
Conversation
…nto emerald-dev
…nto emerald-dev
To fix badge items being added to bag instead of intercepted
…nto emerald-dev
…nto emerald-dev
…ocation is checked
Getting to the gym entrance requires the devon scope; I'm unsure how this ever passed
…nto emerald-dev
…nto emerald-dev
About 6x faster
| 2. Put the tracker pack into packs/ in your PopTracker install. | ||
| 3. Open PopTracker, and load the Pokémon Emerald pack. | ||
| 4. For autotracking, click on the "AP" symbol at the top. | ||
| 5. Enter the AP address, slot name, and password. |
There was a problem hiding this comment.
I'd recommend phrasing this as "Enter the AP Server address", or maybe "... the connection address", or even "the AP connection address" as the Archipelago acronym AP isn't exactly explained in a way that makes this intuitive to a brand new user. I agree with brevity in step-by-step instructions, and think a single word add can be useful here.
There was a problem hiding this comment.
Agreed. Updated in 977a23c
There was a problem hiding this comment.
I have one nitpick, but otherwise I think everything looks pretty good.
Some notes while testing (merged main on top of this during review):
generate_outputtook around 3-4 seconds per file, unsure if that can be improved, but not the worst I've seen of currently implemented worlds. Just something to keep in mind.- Generation appears to be deterministic as well, which is always a good sign.
If you don't mind making that one tweak, I see no reason to hold off this PR anymore.
worlds/pokemon_emerald/pokemon.py
Outdated
| Functions related to pokemon species and moves | ||
| """ | ||
| import time | ||
| from random import Random |
There was a problem hiding this comment.
Rather than (re)import the random module at runtime, I'd recommend doing the following since you're only using it for typing.
if TYPE_CHECKING:
from random import RandomThere was a problem hiding this comment.
Changed in c5da1ee (also needed the strings for type hints)
Yeah, almost all of it is just applying the base patch, creating the final patch, and writing files. Last time I checked procedure patch, it took the entire generation down to <0.5s. The other stuff in |
|
Time to cause chaos. |
What is this fixing or adding?
Adds Pokemon Emerald Version as a new game.
How was this tested?
Many weeks of test games by myself and the AP community. It will likely be played in a few Unsupported games before merging, as well as plenty of games outside the AP discord.
Discord thread: https://discord.com/channels/731205301247803413/1076407822692139080
"Official" beta tests:
https://discord.com/channels/731205301247803413/1106350114777333830
https://discord.com/channels/731205301247803413/756732009052635328/1095491840544870400
https://discord.com/channels/731205301247803413/1122524129514491935
If this makes graphical changes, please attach screenshots.
N/A
Credit
Luc Luc also made some contributions to the mod itself, which don't show up as commits in this PR (GH: luctowers, Discord: lucluc)
I also would like to credit pret in whatever manner seems reasonable for the decomp project and helping figure out specific technical details about the game