WebHost: Change default spoiler-option for games generated from WebHost to 3 instead of 0 #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
changed the title
ThePhar
added
is: bug/fix
|
Rather than override the param default (which I assume was set for a reason), would it not be better to change the endpoint call on the player settings page to pass in the spoiler setting of 3 instead? |
|
We default it to 3 everywhere else in AP so I'm not entirely convinced it was intentional. If it does get done via endpoint call that'd need to be in |
|
i forgot that renaming a branch closes the PR -_- i can look into adding it into the 2 .js files but my JS knowledge is very limited |
ThePhar
changed the title
ThePhar
approved these changes
Jun 23, 2023
Witchybun
pushed a commit
to Witchybun/Archipelago
that referenced
this pull request
Jun 26, 2023
…st to 3 instead of 0 (ArchipelagoMW#1852) * Change default spoiler-option in WebHostLib/generate.py to 3 instead of 0 * shifting spoiler-default to the JS calls instead of setting it in generate.py --------- Co-authored-by: StripesOO7 <54711792+StripeesOO7@users.noreply.github.com>
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…st to 3 instead of 0 (ArchipelagoMW#1852) * Change default spoiler-option in WebHostLib/generate.py to 3 instead of 0 * shifting spoiler-default to the JS calls instead of setting it in generate.py --------- Co-authored-by: StripesOO7 <54711792+StripeesOO7@users.noreply.github.com>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…st to 3 instead of 0 (ArchipelagoMW#1852) * Change default spoiler-option in WebHostLib/generate.py to 3 instead of 0 * shifting spoiler-default to the JS calls instead of setting it in generate.py --------- Co-authored-by: StripesOO7 <54711792+StripeesOO7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Changed the default spoiler-log option in the WebHostLib/generate.py from 0 to 3 to restore spoilerlog generation when generating directly from the Playersettings page.
How was this tested?
If this makes graphical changes, please attach screenshots.