Launcher: keep alive #1894
Merged
Launcher: keep alive #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
the
is: enhancement
black-sliver
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Seems to work for me.
The only gripe I have with our multiprocessing solution now is that it won't join/cleanup the sub-processes until you either spawn another or exit the main application. I'm not sure how this is supposed to be handled with multiprocessing.
e.g.
- open TextClient -> process for TextClient
- close TextClient -> shows process as
<defunct>(because it's not joined) - open TextClient -> joins old process, runs new process
- close TextClient -> shows process as
<defunct> - close Launcher -> joins the defunct process
|
Interesting. That mid-step is not something I had occur, or just not seen it. In my testing I opened Text Client once, closed it, then launcher and then the whole thing exited. |
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Alternative to #1892, that makes each window closable independently.
How was this tested?
Only with TextClient on Windows
If this makes graphical changes, please attach screenshots.