Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Fantasy Mystic Quest: Implement new game #1909

Merged
merged 90 commits into from
Nov 26, 2023

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Jun 29, 2023

What is this fixing or adding?

FFMQR by @wildham0
Uses an API created by wildham for Map Shuffle, Crest Shuffle and Battlefield Reward Shuffle, using a similar method of obtaining data from an external website to Super Metroid's Varia Preset option.
Generates a .apmq file which the user must bring to the FFMQR website https://www.ffmqrando.net/Archipelago to patch their rom. It is not an actual patch file but contains item placement and options data for the FFMQR website to generate a patched rom with for AP.
Some of the AP options may seem unusual, using Choice instead of Range where it may seem more appropriate, but these are options that are passed to FFMQR and I can only be as flexible as it is.

@wildham0 deserves the bulk of the credit for not only creating FFMQR in the first place but all the ASM work on the rom needed to make this possible, work on FFMQR to allow patching with the .apmq files, and creating the API that meant I did not have to recreate his map shuffle from scratch.

How was this tested?

A number of successful beta test sync and async games, including on the FFMQR discord.

@Alchav
Copy link
Contributor Author

Alchav commented Jul 7, 2023

lovely
image

Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code looks good. Only one thing that's actually problematic. Do recommend using the region helpers though those are pretty new. Really wish this had a lot more typing though

worlds/ffmq/__init__.py Outdated Show resolved Hide resolved
worlds/ffmq/__init__.py Show resolved Hide resolved
worlds/ffmq/__init__.py Outdated Show resolved Hide resolved
worlds/ffmq/Items.py Outdated Show resolved Hide resolved
worlds/ffmq/Items.py Outdated Show resolved Hide resolved
worlds/ffmq/Options.py Show resolved Hide resolved
worlds/ffmq/Output.py Outdated Show resolved Hide resolved
worlds/ffmq/Regions.py Show resolved Hide resolved
worlds/ffmq/Regions.py Show resolved Hide resolved
worlds/ffmq/Regions.py Show resolved Hide resolved
option_random_one_through_ten = 6


option_definitions = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to update your options to a dataclass as seen in the docs here.

Access will be simplified in your world as i.e. self.options.option_name.value instead of self.multiworld.option_name[player].value.

@ThePhar
Copy link
Member

ThePhar commented Nov 25, 2023

World/Dev should also be added to the docs/CODEOWNDERS doc.

@Berserker66 Berserker66 merged commit f54f862 into ArchipelagoMW:main Nov 26, 2023
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
FFMQR by @wildham0 
Uses an API created by wildham for Map Shuffle, Crest Shuffle and Battlefield Reward Shuffle, using a similar method of obtaining data from an external website to Super Metroid's Varia Preset option.
Generates a .apmq file which the user must bring to the FFMQR website https://www.ffmqrando.net/Archipelago to patch their rom. It is not an actual patch file but contains item placement and options data for the FFMQR website to generate a patched rom with for AP.
Some of the AP options may seem unusual, using Choice instead of Range where it may seem more appropriate, but these are options that are passed to FFMQR and I can only be as flexible as it is.

@wildham0 deserves the bulk of the credit for not only creating FFMQR in the first place but all the ASM work on the rom needed to make this possible, work on FFMQR to allow patching with the .apmq files, and creating the API that meant I did not have to recreate his map shuffle from scratch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: new game Pull requests for implementing new games into Archipelago.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants