Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs, StS: Document setup for Slay the Spire GOG/Game Pass installations #1913

Merged
merged 6 commits into from
Jul 7, 2023

Conversation

remyjette
Copy link
Collaborator

@remyjette remyjette commented Jun 29, 2023

What is this fixing or adding?

Adds instructions for setting up Slay the Spire using an Xbox Game Pass installation as opposed to Steam

How was this tested?

I went through the steps locally and everything works, both starting a game and sending/receiving items.

If this makes graphical changes, please attach screenshots.

This is what the doc looks like when rendered in the website:

image

@remyjette remyjette changed the title Slay the Spire: Document setup for Game Pass installations Docs: Document setup for Slay the Spire Game Pass installations Jun 29, 2023
@remyjette remyjette changed the title Docs: Document setup for Slay the Spire Game Pass installations Docs: Document setup for Slay the Spire GOG/Game Pass installations Jun 29, 2023
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Jun 30, 2023
@ThePhar ThePhar changed the title Docs: Document setup for Slay the Spire GOG/Game Pass installations Docs, StS: Document setup for Slay the Spire GOG/Game Pass installations Jun 30, 2023
@ThePhar ThePhar requested a review from KonoTyran June 30, 2023 01:06
@KonoTyran
Copy link
Contributor

I'm not a fan of telling the user to just double click on the mod the spire jar file as that will use whatever Java version they may or may not have installed, wich could cause some issues due to version differences, I would perfer including a bat/sh file that would use the bundled version of the jre that comes with StS, on steam this is inside of a jre folder in the sts install directory.

@remyjette
Copy link
Collaborator Author

I'm not a fan of telling the user to just double click on the mod the spire jar file as that will use whatever Java version they may or may not have installed, wich could cause some issues due to version differences, I would perfer including a bat/sh file that would use the bundled version of the jre that comes with StS, on steam this is inside of a jre folder in the sts install directory.

My understanding is ModTheSpire.jar will swap to the local StS JRE even if you originally launched it with a different JRE

for example

D:\XboxGames\Slay The Spire\Content>"C:\Program Files (x86)\Common Files\Oracle\Java\javapath\java.exe" -jar ModTheSpire.jar
Searching for Workshop items...
Using local StS JRE @ D:\XboxGames\Slay The Spire\Content\jre\bin\java.exe

With that being said I'm going to change it anyway. Double-clicking ModTheSpire.jar isn't ideal because even if it would swap to the bundled JRE that isn't a good experience for anyone who doesn't have Java in their PATH.

Co-authored-by: KonoTyran <Kono.Tyran@gmail.com>
@ThePhar ThePhar merged commit feaa30d into ArchipelagoMW:main Jul 7, 2023
7 checks passed
@remyjette remyjette deleted the sts-gamepass-docs branch July 21, 2023 01:26
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants