-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LADX: Fix being forced to farm for money, fix set iteration #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
changed the title
Draft: Fix being forced to farm for money
LADX: Draft: Fix being forced to farm for money
Jul 2, 2023
ThePhar
added
the
is: bug/fix
Issues that are reporting bugs or pull requests that are fixing bugs.
label
Jul 2, 2023
If possible, I would recommend against opening a Draft PR unless the goal is to get feedback from the proposed changes to help shape the PR during development. I didn't see that implication in the description (no info in the description at the time of this writing). |
ThePhar
changed the title
LADX: Draft: Fix being forced to farm for money
LADX: Fix being forced to farm for money
Jul 2, 2023
zig-for
changed the title
LADX: Fix being forced to farm for money
LADX: Fix being forced to farm for money, fix set iteration
Jul 3, 2023
Berserker66
reviewed
Jul 3, 2023
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Berserker66
approved these changes
Jul 4, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
1a. Turned on counting of 20s and 50s as otherwise some spots weren't logically reachable
1b. Added code for rupee overflow that's currently disabled - needs UI work otherwise it may be confusing
How was this tested?
Made a bunch of generations with swords in rupee locked places
If this makes graphical changes, please attach screenshots.
Enjoy this terrible spoiler