WebHost: Fix as_dict attribute error #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 827444f
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Dragion147
added a commit
to YutskiLGC/Archipelago
that referenced
this pull request
Jul 16, 2023
WebHost: Fix as_dict attribute error (ArchipelagoMW#1977)
Dragion147
added a commit
to YutskiLGC/Archipelago
that referenced
this pull request
Jul 16, 2023
WebHost: Fix as_dict attribute error (ArchipelagoMW#1977)
ThePhar
added
is: bug/fix
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* WebHost: Fix as_dict attribute error Introduced in 827444f * WebHost: Add assertion that baked_server_options is a dict Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
* WebHost: Fix as_dict attribute error Introduced in 827444f * WebHost: Add assertion that baked_server_options is a dict Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* WebHost: Fix as_dict attribute error Introduced in 827444f * WebHost: Add assertion that baked_server_options is a dict Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Moves conversion of server options to dict to avoid causing an AttributeError when
baked_server_optionsis notNone. Introduced in 827444fHow was this tested?
Running the webhost locally and generating a couple seeds.