Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: ensure unreachable_regions is correctly set #1985

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Tests: ensure unreachable_regions is correctly set #1985

merged 1 commit into from
Jul 18, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

also tests the reverse case of reachable regions

How was this tested?

yes

If this makes graphical changes, please attach screenshots.

black-sliver
black-sliver approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be cases where reachable depends on seed, i.e. imagine SM having random starting location by default, but whoever needs that could add a second set of exclusions when they need it and this works fine for our current worlds.

@Berserker66 Berserker66 merged commit 60586aa into main Jul 18, 2023
21 checks passed
@Berserker66 Berserker66 deleted the tests_test_unreachable_regions branch July 18, 2023 10:41
@ThePhar ThePhar added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. affects: core Issues/PRs that touch core and may need additional validation. labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Berserker66 @black-sliver @ThePhar