Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stardew Valley: Fixed Leo's Treehouse being randomized too aggressively #1992

Merged

Conversation

agilbert1412
Copy link
Collaborator

What is this fixing or adding?

Leo's TreeHouse is an entrance that only opens after unlocking Ginger Island, meeting Leo, and earning 6 hearts with him. Therefore, in the randomizer, this entrance requires progression items.

This change fixes a bug where the entrance was randomized under the "Non-progression" setting. It is now correctly under the "Buildings" setting

Additional fix for a very unlikely entrance randomizer softlock: Void Mayonnaise can be fished from the witch's swamp, and this has been added in logic to avoid problems with obtaining void eggs making an infinite loop there

How was this tested?

Ran the automated tests and checked the result of randomization. Generate a few manual multiworlds

@ThePhar ThePhar changed the title Stardew Valley - Fixed Leo's Treehouse being randomized too aggressively Stardew Valley: Fixed Leo's Treehouse being randomized too aggressively Jul 19, 2023
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jul 19, 2023
@black-sliver black-sliver merged commit 257774c into ArchipelagoMW:main Jul 19, 2023
12 checks passed
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…ly (ArchipelagoMW#1992)

* - Fixed Leo's Treehouse being randomized too aggressively

* - Added an automated test to catch badly tagged Non-progression entrances

* - Fixed a logic issue with Void Mayonnaise not being fishable

* - Removed unused import
@agilbert1412 agilbert1412 deleted the StardewValley/TreeHouseFix branch December 6, 2023 14:42
kl3cks7r pushed a commit to kl3cks7r/Archipelago that referenced this pull request Dec 15, 2023
…ly (ArchipelagoMW#1992)

* - Fixed Leo's Treehouse being randomized too aggressively

* - Added an automated test to catch badly tagged Non-progression entrances

* - Fixed a logic issue with Void Mayonnaise not being fishable

* - Removed unused import
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…ly (ArchipelagoMW#1992)

* - Fixed Leo's Treehouse being randomized too aggressively

* - Added an automated test to catch badly tagged Non-progression entrances

* - Fixed a logic issue with Void Mayonnaise not being fishable

* - Removed unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants