Core: Add dict functionality to OptionDict #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of selectively implementing some methods, you might want to consider the See here for an example. |
ThePhar
added
is: enhancement
ThePhar
changed the title
items() and __getitem__ to OptionDictitems() and __getitem__ to OptionDict
alwaysintreble
changed the title
items() and __getitem__ to OptionDict
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
black-sliver
approved these changes
Jul 30, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* Options: Add support for `items()` and `__getitem__` to OptionDict * Options: have OptionDict inherit from Mapping * add typing to __getitem__ Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
* Options: Add support for `items()` and `__getitem__` to OptionDict * Options: have OptionDict inherit from Mapping * add typing to __getitem__ Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* Options: Add support for `items()` and `__getitem__` to OptionDict * Options: have OptionDict inherit from Mapping * add typing to __getitem__ Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com> --------- Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Title. It seemed weird to me that these aren't really supported by the "OptionDict". I think if you make something that isn't actually a dict, you probably know to override or not use these.
How was this tested?
Put it in The Messenger and generated a few seeds/debugged.
If this makes graphical changes, please attach screenshots.