The Messenger: actually implement get_filler_item_name
#2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berserker66
reviewed
Aug 1, 2023
worlds/messenger/__init__.py
Outdated
Comment on lines
174
to
176
| self._filler_items = [name for name in self.random.choices(list(FILLER), | ||
| weights=list(FILLER.values()), | ||
| k=100)] |
There was a problem hiding this comment.
Suggested change
| self._filler_items = [name for name in self.random.choices(list(FILLER), | |
| weights=list(FILLER.values()), | |
| k=100)] | |
| self._filler_items = self.random.choices(list(FILLER), weights=list(FILLER.values()), k=20) |
There was a problem hiding this comment.
i guess it's better to have a smaller cache, and need to create it more frequently, than just create a too large one once?
There was a problem hiding this comment.
in my experience, probably yes. I did not benchmark it.
Berserker66
reviewed
Aug 1, 2023
worlds/messenger/__init__.py
Outdated
Comment on lines
136
to
142
| self._filler_items = [name | ||
| for name in | ||
| self.random.choices( | ||
| list(filler_pool), | ||
| weights=list(filler_pool.values()), | ||
| k=remaining_fill | ||
| )] |
There was a problem hiding this comment.
Suggested change
| self._filler_items = [name | |
| for name in | |
| self.random.choices( | |
| list(filler_pool), | |
| weights=list(filler_pool.values()), | |
| k=remaining_fill | |
| )] | |
| self._filler_items = self.random.choices( | |
| list(filler_pool), | |
| weights=list(filler_pool.values()), | |
| k=remaining_fill | |
| ) |
formatting is not easily fixable in this editor.
Berserker66
reviewed
Aug 1, 2023
worlds/messenger/__init__.py
Outdated
| filler_pool = dict(list(FILLER.items())[2:]) | ||
| self._filler_items = self.random.choices( | ||
| list(filler_pool), | ||
| weights=list(filler_pool.values()), |
There was a problem hiding this comment.
I can't help but notice a list(dict(list row of calls to arrive here.. which smells bad.
There was a problem hiding this comment.
i want it to remain as a dict, but i trim off the first few key, value pairs. is there a better way to do that?
Berserker66
approved these changes
Aug 1, 2023
ThePhar
added
the
is: enhancement
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Returns more proper filler for item links instead of hardcoded "Time Shard" which is basically worthless. The 100 is a completely arbitrary number, could be any number really, but that should be enough to satisfy most multiworlds, as maximum filler generated without starting_inventory is 98. This isn't high priority, as it really only has an effect on item links.
How was this tested?
Generated a few multiworlds to satisfy all the different combinations and tests.
If this makes graphical changes, please attach screenshots.