Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Small typo and proofreading edits #2078

Merged
merged 16 commits into from
Sep 10, 2023

Conversation

nicholassaylor
Copy link
Contributor

@nicholassaylor nicholassaylor commented Aug 3, 2023

What is this fixing or adding?

Modifying game and set-up pages for typos, confusing/redundant sentences, and clarity.
No information was removed from these pages, and in some cases, clarifying information was added.

How was this tested?

Looking at rendered markdown

Lists made more concise, space added between "generated weapons" and open parenthesis
Fixed minor typos and reworded sentences for conciseness.
Refined style, capitalization, and sentence structure for clarity
Each nest needed an additional 2 spaces
Made various edits to redundancy within the page as well as omitted/unclear information
Small capitalization consistency edits and slight rewording for conciseness
Copy link
Collaborator

@Silvris Silvris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a couple of nitpicks. The maintainers for Final Fantasy, KH2, and RoR2 should probably sign off on this before it gets merged, as these contained larger edits.

worlds/ff1/docs/multiworld_en.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
nicholassaylor and others added 4 commits August 3, 2023 10:29
Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Include Drive Forms and Summons
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Aug 16, 2023
@ThePhar
Copy link
Member

ThePhar commented Aug 16, 2023

Pinging code owners for worlds touched to review.

Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validated the Stardew Valley changes only

Copy link
Collaborator

@kindasneaki kindasneaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to fix the one change, and then it looks good to me

worlds/ror2/docs/en_Risk of Rain 2.md Outdated Show resolved Hide resolved
nicholassaylor and others added 2 commits August 16, 2023 15:31
Co-Authored-By: kindasneaki <19377912+kindasneaki@users.noreply.github.com>
Copy link
Collaborator

@jtoyoda jtoyoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for FF1

@JaredWeakStrike
Copy link
Collaborator

The KH2 changes look good and I approve

@KonoTyran
Copy link
Contributor

@Marechal-L last ok we need to merge this.

@black-sliver
Copy link
Member

@Br00ty or @Zunawe please check and approve/reject DS3

Copy link
Collaborator

@Zunawe Zunawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are fine. As mentioned in Discord, the page could use a rewrite to better reflect the recent changes. I'll open a PR in a minute for that.

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we got approvals from all involved games.

@black-sliver black-sliver merged commit a1418cc into ArchipelagoMW:main Sep 10, 2023
7 checks passed
@nicholassaylor nicholassaylor deleted the typo-fix branch September 10, 2023 01:32
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
* Slight rewording of DS3 game page

Lists made more concise, space added between "generated weapons" and open parenthesis

* Proofread Final Fantasy pages

Fixed minor typos and reworded sentences for conciseness.

* Edited Kingdom Hearts 2 Game Page

Refined style, capitalization, and sentence structure for clarity

* Fixed nested list in Minecraft game page

Each nest needed an additional 2 spaces

* Edited Risk of Rain 2 Game Page

Made various edits to redundancy within the page as well as omitted/unclear information

* Edited Stardew Valley game page

Small capitalization consistency edits and slight rewording for conciseness

* Update worlds/ff1/docs/multiworld_en.md

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>

* Add information for EXP multiplier

Include Drive Forms and Summons

* Correction for Newt Altars RoR2

Co-Authored-By: kindasneaki <19377912+kindasneaki@users.noreply.github.com>

---------

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Co-authored-by: kindasneaki <19377912+kindasneaki@users.noreply.github.com>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
* Slight rewording of DS3 game page

Lists made more concise, space added between "generated weapons" and open parenthesis

* Proofread Final Fantasy pages

Fixed minor typos and reworded sentences for conciseness.

* Edited Kingdom Hearts 2 Game Page

Refined style, capitalization, and sentence structure for clarity

* Fixed nested list in Minecraft game page

Each nest needed an additional 2 spaces

* Edited Risk of Rain 2 Game Page

Made various edits to redundancy within the page as well as omitted/unclear information

* Edited Stardew Valley game page

Small capitalization consistency edits and slight rewording for conciseness

* Update worlds/ff1/docs/multiworld_en.md

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>

* Add information for EXP multiplier

Include Drive Forms and Summons

* Correction for Newt Altars RoR2

Co-Authored-By: kindasneaki <19377912+kindasneaki@users.noreply.github.com>

---------

Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Co-authored-by: kindasneaki <19377912+kindasneaki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants