Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: create terminal capable Launcher #2111

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

Berserker66
Copy link
Member

@Berserker66 Berserker66 commented Aug 18, 2023

What is this fixing or adding?

adds stderr/stdout capable launcher to windows.
In turn, this allows use of --help or to capture errors before log init.

How was this tested?

https://discord.com/channels/731205301247803413/1141562528632152135

If this makes graphical changes, please attach screenshots.

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw seems to build and work. i'm not 100% sure we need that in the default distribution as it is though. a --debug, --console or --nogui switch might be better for general purpose.

@el-u
Copy link
Collaborator

el-u commented Aug 27, 2023

Tested; seems to do what it is supposed to do.

@Berserker66 Berserker66 merged commit 30e747b into main Aug 29, 2023
16 checks passed
@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels Oct 16, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants