Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sm64ex: All Bowser Stages Goal #2112

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Conversation

N00byKing
Copy link
Collaborator

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

New goal for sm64ex, instead of just BitS this requires completing both BitDW and BitFS as well.
Was asked for on discord, felt like adding it.

How was this tested?

Generated, playtested.
If someone is interested in testing this, note that sm64ex needs to be compiled on branch ap_test

If this makes graphical changes, please attach screenshots.

worlds/sm64ex/Rules.py Outdated Show resolved Hide resolved
worlds/sm64ex/Rules.py Outdated Show resolved Hide resolved
N00byKing and others added 2 commits August 26, 2023 00:46
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
@N00byKing
Copy link
Collaborator Author

Didn't know you can just access the option without .value, neat.

worlds/sm64ex/Rules.py Outdated Show resolved Hide resolved
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
@N00byKing
Copy link
Collaborator Author

Bump for re-review

@ScootyPuffJr1 ScootyPuffJr1 added the is: enhancement Issues requesting new features or pull requests implementing new features. label Oct 16, 2023
@Berserker66 Berserker66 merged commit 253f3e6 into ArchipelagoMW:main Oct 28, 2023
12 checks passed
@N00byKing N00byKing deleted the sm64_goals branch October 28, 2023 22:38
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants