SC2 WoL: Mod, Item and Location update #2113
Conversation
|
I'm not entirely sure how big this is, as I can't even load the full files changed tab, but having so many misc files for the mod in the main AP repo is a no go. I would highly suggest you to host the mod in your own repo, and have the python client that is shipped with AP just download the needed mod files from that repo. Any files included here will have to be downloaded by all people wishing to play AP, as they all get included in the installer. so we really don't want people to have to download the entirety of WoL inside of the AP installer if they have no intention of playing StarCraft in AP. |
|
Since it was requested I review this here, I'll repeat here what I said on Discord: This PR is absolutely absurd. I don't want to have to clone all of this crap, and I'm of the opinion that it should be immediately rejected on principle. |
|
The other thing that the mod version shall be synchronized with the client version See also https://discord.com/channels/731205301247803413/731214280439103580/1144607092112625754 |
|
I've moved the map/mod data to a new repo: https://github.com/Ziktofel/Archipelago-SC2-data/tree/sc2-wol-new |
…trigger a launching screen
ThePhar
changed the title
ThePhar
added
is: documentation
Migrates SC2 WoL world to the new mod with new items and locations. The new mod has a different architecture making it more future proof (with planned adding of other campaigns). Also gets rid of several old bugs Adds new short game formats intended for sync games (Tiny Grid, Mini Gauntlet). The final mission isn't decided by campaign length anymore but it's configurable instead. Allow excluding missions for Vanilla Shuffled, corrected some documentation. NOTE: This is a squashed commit with Salz' HotS excluded (not ready for the release and I plan multi-campaign instead) --------- Co-authored-by: Matthew <matthew.marinets@gmail.com>
Migrates SC2 WoL world to the new mod with new items and locations. The new mod has a different architecture making it more future proof (with planned adding of other campaigns). Also gets rid of several old bugs Adds new short game formats intended for sync games (Tiny Grid, Mini Gauntlet). The final mission isn't decided by campaign length anymore but it's configurable instead. Allow excluding missions for Vanilla Shuffled, corrected some documentation. NOTE: This is a squashed commit with Salz' HotS excluded (not ready for the release and I plan multi-campaign instead) --------- Co-authored-by: Matthew <matthew.marinets@gmail.com>
What is this fixing or adding?
Migrates SC2 WoL world to the new mod with new items and locations. The new mod has a different architecture making it more future proof (with planned adding of other campaigns). Also gets rid of several old bugs
Adds new short game formats intended for sync games (Tiny Grid, Mini Gauntlet). The final mission isn't decided by campaign length anymore but it's configurable instead. Allow excluding missions for Vanilla Shuffled, corrected some documentation.
NOTE: This is a squashed commit with Salz' HotS excluded (not ready for the release and I plan multi-campaign instead)
How was this tested?
Completed several games, including multiworld async, Joining release games works (but there are some differences in UX given the way how the new mod works)
Also generated and verified a lot of games if they got generated correctly
If this makes graphical changes, please attach screenshots.
The tracker got updated for the new stuff