Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorio: Fix typos in options tooltip #2121

Merged
merged 6 commits into from
Sep 10, 2023

Conversation

budak7273
Copy link
Contributor

What is this fixing or adding?

  • Fix some typos in the Factorio options tooltip for Tech Tree Information
  • Add more details to the tooltip for the Advancement option

How was this tested?

Locally running WebHost.py after making the changes, used to capture the screenshot below

If this makes graphical changes, please attach screenshots.

Before:
image

After:
image

Copy link
Collaborator

@Silvris Silvris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor edit suggestion for consistency, otherwise it looks good to me, even without the edit.

worlds/factorio/Options.py Outdated Show resolved Hide resolved
worlds/factorio/Options.py Outdated Show resolved Hide resolved
It doesn't let me apply more than one change to the same line in a batch.

Co-authored-by: Scipio Wright <scipiowright@gmail.com>
worlds/factorio/Options.py Outdated Show resolved Hide resolved
It doesn't let me apply more than one change to the same line in a batch.
@black-sliver black-sliver merged commit 3d98376 into ArchipelagoMW:main Sep 10, 2023
12 checks passed
@budak7273 budak7273 deleted the budak7273-patch-1 branch September 10, 2023 22:14
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Oct 16, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…MW#2121)

* Fix typo in Factorio options tooltip

* Fix typo, add details

* Apply code review suggestion

It doesn't let me apply more than one change to the same line in a batch.

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

* Apply code review suggestion from @nicholassaylor

It doesn't let me apply more than one change to the same line in a batch.

---------

Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…MW#2121)

* Fix typo in Factorio options tooltip

* Fix typo, add details

* Apply code review suggestion

It doesn't let me apply more than one change to the same line in a batch.

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

* Apply code review suggestion from @nicholassaylor

It doesn't let me apply more than one change to the same line in a batch.

---------

Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants