WebHost: Support multi-select during check/generate file upload #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the user to select multiple YAML files via Shift-Click or Control-Click in their browser when generating a game via the site instead of having to zip them locally first.
remyjette
changed the title
agilbert1412
approved these changes
Sep 1, 2023
Berserker66
approved these changes
Sep 11, 2023
Updated generate.html to say "File(s)" check.html just says "Upload" so I left it as-is, but I can change to "Upload File(s)" for consistency if you want |
|
Consistency does sound nice to me. @LegendaryLinux any comments? |
LegendaryLinux
approved these changes
Sep 11, 2023
ThePhar
added
is: enhancement
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…ipelagoMW#2138) * Support multi-select during check/generate file upload This will allow the user to select multiple YAML files via Shift-Click or Control-Click in their browser when generating a game via the site instead of having to zip them locally first. * Update generate.html: File -> File(s) * Change check.html button text to "Upload File(s)" to match generate.html
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…ipelagoMW#2138) * Support multi-select during check/generate file upload This will allow the user to select multiple YAML files via Shift-Click or Control-Click in their browser when generating a game via the site instead of having to zip them locally first. * Update generate.html: File -> File(s) * Change check.html button text to "Upload File(s)" to match generate.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This will allow the user to select multiple YAML files via Shift-Click or Control-Click in their browser when generating a game via the site instead of having to zip them locally first.
Implements this suggestion from #general-suggestions: https://discord.com/channels/731205301247803413/1139359972401102940
There were some suggestions in that thread to make this even better that aren't implemented here, but I agree with " just allowing multi-select in the prompt would go a long, long ways to make it easier" and chose to implement that for now.
How was this tested?
Locally by running WebHost.py. Validated that single-YAML and single-zip uploads still work as expected, then also tried multiple YAMLs. For fun I also tried multiple zips, then a zip+yaml upload and those worked too. I don't think multiple zips or zip+yamls is a particularly common use case but I see no reason to block it either.
If this makes graphical changes, please attach screenshots.