Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/LttP: remove can_reach_private #2140

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Core/LttP: remove can_reach_private #2140

merged 1 commit into from
Aug 31, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

nothing

How was this tested?

unittest and find usage

black-sliver
black-sliver approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my guess is this was replaced by indirect connections

@Berserker66 Berserker66 merged commit 77a349c into main Aug 31, 2023
21 checks passed
@Berserker66 Berserker66 deleted the remove_can_reach_private branch August 31, 2023 20:10
@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization. affects: core Issues/PRs that touch core and may need additional validation. labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Berserker66 @black-sliver @ThePhar