Witness: Bug fixes. #2161
Witness: Bug fixes. #2161
Conversation
This fixes two problems: - A crash in the early "good" item placement on the tutorial gate when a plando contained an item not in the good item list - Crashes when processing malformed plando settings that represent items as nested structures.
…l children are placed early.
|
For the record, the first bullet point is not actually in this PR, this is that git issue again where commits from last PR are showing up again bc of the use of squash merge. (Look at "files changed", only the progressive items thing is actually part of this PR) I probably can't always fix that myself, I have a way around the issue but I'm not sure you'd like it (I do history rewrites via git reset [last_clean_commit] --hard -> git rebase upstream/main -> push --force). The strategy suggested by the AP devs is to use a feature branch for any change, and never actually commit or merge anything into NewSoupVi/main, except merging upstream/main into NewSoupVi/main once a PR has made it through. We can switch to this strategy if you like. You can also look into the issue yourself to figure out a cleaner way for how to prevent it, feel free to discuss the issue with me ofc |
ThePhar
added
the
is: bug/fix
What is this fixing or adding?