Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zillion: ensure 1st sphere not empty #2190

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented Sep 16, 2023

What is this fixing or adding?

Zillion could rarely have no locations in 1st sphere

https://github.com/ArchipelagoMW/Archipelago/actions/runs/6191949342/job/16811145959

How was this tested?

unit tests (in both zilliandomizer package and AP)

and playing through an AP game

@black-sliver
Copy link
Member

MakeFailure leads to rerolling the room/layout?

@beauxq
Copy link
Collaborator Author

beauxq commented Sep 17, 2023

MakeFailure leads to rerolling the room/layout?

Yes, for that room.

If you roll a seed with the room gen option on zilliandomizer (not Archipelago), you can get a good idea of what is happening.
It displays in the console a period . for each time it rerolls a room. It often rerolls 10-20 times per room to get something that works. This change adds a very low probability of reroll on 1 room.

Note that the room gen is not run in unit tests, since it requires information from the rom.
So only the changes in src/zilliandomizer/randomizer.py affect the unit test failures. (The vanilla room layout already has the property ensured by the room gen changes.)

@black-sliver black-sliver merged commit b24037e into ArchipelagoMW:main Sep 17, 2023
7 checks passed
@ThePhar ThePhar added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants