DS3: Add cinders item group #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
It functions. Would be neat for there to be more item name groups too, but it's understandable why there wouldn't be any based on the items in the game. I don't really see anyone hinting for groups of things other than the Cinders.
Maybe a key items group, so that you can easily local all of your key items in your yaml?
|
Good idea, I definitely approve this change |
Berserker66
approved these changes
Sep 30, 2023
ThePhar
added
the
is: enhancement
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
@Marechal-L
Adds a "Cinders" item group. These are all functionally the same, so there's no reason to hint for any specific one over another. Usually you just have to try to remember which ones you have and don't have before you hint for one.
How was this tested?
Generating a seed and hinting for "Cinders".