Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Pokemon RB Spanish Setup Guide: fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section #2228

Merged
merged 13 commits into from
Oct 7, 2023

Conversation

ShinyNT
Copy link
Contributor

@ShinyNT ShinyNT commented Sep 26, 2023

What is this fixing or adding?

Fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section

How was this tested?

By me reading the whole guide again

If this makes graphical changes, please attach screenshots.

hopefully should fix this:
image

setup_en 100% translated (with a bit of adaptation to spanish linguistics)
add reference to the spanish tutorial
removed temporary "wip translation" header
formatting cleanup
translated "alias for" on lines 73 and 74, which I just forgot to
fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section
@ShinyNT ShinyNT changed the title Pokemon RB: Spanish Setup Guide: fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section Docs: Pokemon RB Spanish Setup Guide: fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section Sep 26, 2023
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking over everything, all of the changes seem reasonable. However, my Spanish is limited, which is why I am not submitting my review as an Approval.

I looked at the bold formatting and provided an alternative that you might want to look at.

worlds/pokemon_rb/docs/setup_es.md Outdated Show resolved Hide resolved
ShinyNT and others added 2 commits September 26, 2023 20:43
updated bold format as per nicholassaylor's suggestion

Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
@black-sliver
Copy link
Member

Bold text renders correctly. I don't speak Spanish, but looking at the changes and the fact that the original was by ShinyNT as well, I'm guessing it should be fine.

@black-sliver black-sliver merged commit debdd4c into ArchipelagoMW:main Oct 7, 2023
7 checks passed
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…ammar and fixed bold format in Configuring Bizhawk section (ArchipelagoMW#2228)

* added setup_es.md

setup_en 100% translated (with a bit of adaptation to spanish linguistics)

* Update __init__.py

add reference to the spanish tutorial

* Update setup_es.md

removed temporary "wip translation" header

* Update setup_es.md

formatting cleanup

* Update setup_es.md

translated "alias for" on lines 73 and 74, which I just forgot to

* Update setup_es.md

fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section

* Update worlds/pokemon_rb/docs/setup_es.md

updated bold format as per nicholassaylor's suggestion

Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>

---------

Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…ammar and fixed bold format in Configuring Bizhawk section (ArchipelagoMW#2228)

* added setup_es.md

setup_en 100% translated (with a bit of adaptation to spanish linguistics)

* Update __init__.py

add reference to the spanish tutorial

* Update setup_es.md

removed temporary "wip translation" header

* Update setup_es.md

formatting cleanup

* Update setup_es.md

translated "alias for" on lines 73 and 74, which I just forgot to

* Update setup_es.md

fixed a bunch of punctuation/grammar and fixed bold format in Configuring Bizhawk section

* Update worlds/pokemon_rb/docs/setup_es.md

updated bold format as per nicholassaylor's suggestion

Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>

---------

Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants