Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add info to turn on github actions #2264

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Docs: add info to turn on github actions #2264

merged 5 commits into from
Oct 5, 2023

Conversation

kindasneaki
Copy link
Collaborator

What is this fixing or adding?

title see https://discord.com/channels/731205301247803413/731214280439103580/1158657594181812304

How was this tested?

didn't

If this makes graphical changes, please attach screenshots.

@black-sliver
Copy link
Member

Looks like you forgot to add the image?
Also I think the sentence is missing something at end - maybe "when pushing"

@nicholassaylor
Copy link
Contributor

Like black sliver said, the image is not included in the PR.

I think that the automated workflows are also enabled when you accept and enable them on the Actions page since AP has them turned on already.

@kindasneaki
Copy link
Collaborator Author

making sure things are checked when pushing is hard apparently

@el-u
Copy link
Collaborator

el-u commented Oct 4, 2023 •
edited

  • Might be worth mentioning that this is something that you have to do on your fork
  • I think it might flow better if the new point was added at the second position instead of the last
    (judging purely from the information provided by the sentences; of course moving that large image to that position would have its downsides)

@black-sliver
Copy link
Member

maybe shrink the image? i think you can still make out the red circles at half height

@kindasneaki kindasneaki changed the title [Docs] add info to turn on github actions Docs add info to turn on github actions Oct 5, 2023
@kindasneaki kindasneaki changed the title Docs add info to turn on github actions Docs: add info to turn on github actions Oct 5, 2023
black-sliver
black-sliver approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@black-sliver black-sliver merged commit bb09811 into ArchipelagoMW:main Oct 5, 2023
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Oct 17, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
@kindasneaki @FlySniper
Docs: add info to turn on github actions (ArchipelagoMW#2264)
2ae61d4 
* add info to turn on github actions

* add missing image

* add when pushing

* reduce picture size

* mention editing actions on your fork instead
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@kindasneaki @Jouramie
Docs: add info to turn on github actions (ArchipelagoMW#2264)
791f0d9 
* add info to turn on github actions

* add missing image

* add when pushing

* reduce picture size

* mention editing actions on your fork instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

@el-u el-u el-u approved these changes

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kindasneaki @black-sliver @nicholassaylor @el-u @ThePhar