Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2: 0.4.3 bugfixes #2273

Merged
merged 13 commits into from
Nov 8, 2023
Merged

Conversation

Ziktofel
Copy link
Collaborator

@Ziktofel Ziktofel commented Oct 5, 2023

What is this fixing or adding?

Fixes few minor generation-related bugs:

How was this tested?

Generated few affected games and some other ones, launched the client and connected to the slot
See also:
Ziktofel#59
Ziktofel#58
Ziktofel#66

@Ziktofel Ziktofel changed the title Sc2 043 bugfixes [SC2] 0.4.3 bugfixes Oct 5, 2023
@Ziktofel Ziktofel changed the title [SC2] 0.4.3 bugfixes SC2: 0.4.3 bugfixes Oct 5, 2023
Copy link
Contributor

@MatthewMarinets MatthewMarinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 17, 2023
@ThePhar
Copy link
Member

ThePhar commented Nov 2, 2023

Since you changed the name of some of the locations, please increment data_version by one. Hopefully only a little while longer until we can completely drop data_version support from core.

@Ziktofel
Copy link
Collaborator Author

Ziktofel commented Nov 7, 2023

Done

@ThePhar ThePhar merged commit 154e17f into ArchipelagoMW:main Nov 8, 2023
12 checks passed
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Co-authored-by: Matthew <matthew.marinets@gmail.com>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Co-authored-by: Matthew <matthew.marinets@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants