The Messenger: Make modules and tests PEP8 #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-u
reviewed
Oct 5, 2023
el-u
reviewed
Oct 7, 2023
There was a problem hiding this comment.
A few easy things that you could fix while you're at it:
worlds/messenger/rules.py:122:1: W293 blank line contains whitespace
worlds/messenger/test/test_locations.py:13:1: W293 blank line contains whitespace
worlds/messenger/test/test_logic.py:1:1: F401 'typing.Iterable' imported but unused
worlds/messenger/test/test_logic.py:1:1: F401 'typing.List' imported but unused
worlds/messenger/test/test_logic.py:84:1: W293 blank line contains whitespace
el-u
approved these changes
Oct 8, 2023
black-sliver
approved these changes
Oct 8, 2023
ThePhar
added
the
is: refactor/cleanup
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* The Messenger: PEP8 module and test names * fix dumb * whitespace
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* The Messenger: PEP8 module and test names * fix dumb * whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
style
How was this tested?
unit tests and a few generations. Mostly just renames files and test methods