Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoE: v046 update #2281

Merged
merged 2 commits into from
Oct 24, 2023
Merged

SoE: v046 update #2281

merged 2 commits into from
Oct 24, 2023

Conversation

black-sliver
Copy link
Member

@black-sliver black-sliver commented Oct 8, 2023

What is this fixing or adding?

SoE update to latest upstream version

  • install via pypi, pin hashes
  • add OoB logic option
  • add sequence break logic option
  • fix turd ball texts
  • add option to fix OoB
  • better textbox handling when turning in energy core fragments

Changes to Module update

  • allow multi-line entries in requirements.txt (ending in \)
  • allow --hash to appear in a requirement
    • hash will only be checked during install, not when checking already-installed modules

Other changes

  • rename test files to match the new scheme (defs will come later)
  • don't try to import pyevermizer from source (this led to confusing error messages previously)
  • switch to PyPI adds prebuilt packages for py 3.12

How was this tested?

  • Upstream v046 was tested by the Evermizer community
  • Unit tests
  • Couple of gens

* install via pypi, pin hashes
* add OoB logic option
* add sequence break logic option
* fix turd ball texts
* add option to fix OoB
* better textbox handling when turning in energy core fragments
@alwaysintreble
Copy link
Collaborator

alwaysintreble commented Oct 10, 2023

not sure i understand the benefit of the hash, but doesn't seem to hurt anything at least. it's strange that you renamed all your test modules to test_ but not the methods though

@black-sliver
Copy link
Member Author

not sure i understand the benefit of the hash

Basic concept is this: https://pip.pypa.io/en/stable/topics/repeatable-installs/

it's strange that you renamed all your test modules to test_ but not the methods though

Renaming the files is the only thing required to get the tests to run on linux, so i wanted to get that done asap. Cleaning up the world (and PEPing it up) can be done in a follow-up PR. Updating to 993-style options and maybe renaming the modules and getting rid of the logic mixin is all cleanup that may happen some day.

@ThePhar ThePhar added the is: enhancement Issues requesting new features or pull requests implementing new features. label Oct 17, 2023
@black-sliver black-sliver merged commit e87d5d5 into ArchipelagoMW:main Oct 24, 2023
12 checks passed
@black-sliver black-sliver deleted the soe-046 branch October 24, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants