Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMBN3: Small Bug Fixes #2282

Merged
merged 5 commits into from
Nov 24, 2023
Merged

MMBN3: Small Bug Fixes #2282

merged 5 commits into from
Nov 24, 2023

Conversation

digiholic
Copy link
Collaborator

What is this fixing or adding?

  • Fixes a text box index causing the wrong message to be replaced in the Yoka Zoo Garbage Can, which led to getting both the randomizer item and the original Repair * Chip that is found there in vanilla
  • Changes item handling mode so starting inventory is properly sent by the server
  • Changes logic to prevent progressive items from ending up on WWW Island, so games can no longer be BK'd waiting for MMBN3 to completely finish the game

How was this tested?

  • Local seeds generated and checked manually

el-u
el-u reviewed Oct 8, 2023
View reviewed changes
worlds/mmbn3/__init__.py Outdated Show resolved Hide resolved
@ScootyPuffJr1 ScootyPuffJr1 added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 16, 2023
@ThePhar ThePhar changed the title [MMBN3] Small Bug Fixes MMBN3: Small Bug Fixes Oct 17, 2023
ThePhar
ThePhar requested changes Nov 8, 2023
View reviewed changes
worlds/mmbn3/__init__.py Outdated Show resolved Hide resolved
digiholic and others added 2 commits November 24, 2023 09:37
@digiholic @el-u
Update worlds/mmbn3/__init__.py
95528ea 
Co-authored-by: el-u <109771707+el-u@users.noreply.github.com>
@digiholic @ThePhar
Update worlds/mmbn3/__init__.py
fc38f95 
Co-authored-by: Zach Parks <zach@alliware.com>
@ThePhar ThePhar merged commit 4641456 into ArchipelagoMW:main Nov 24, 2023
8 of 12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@digiholic @el-u
@ThePhar @Jouramie
MMBN3: Small Bug Fixes (ArchipelagoMW#2282)
d61e873 
Co-authored-by: el-u <109771707+el-u@users.noreply.github.com>
Co-authored-by: Zach Parks <zach@alliware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@el-u el-u el-u left review comments

@ThePhar ThePhar ThePhar approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digiholic @ThePhar @el-u @ScootyPuffJr1