Core: guard against plandoing items onto event locations #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would the proper fix not be to allow plandoing events and setting an item rule on the locations? |
|
I want to make this a generic fix, not just by putting item rules on the oot locations. I'm also hesitant to do anything which prevents custom behavior around filling event items onto locations and items onto event locations, since it's probably valuable to be able to do that internally. |
ThePhar
added
is: enhancement
removes the previous filtering on early_locations since it should no longer be needed
Berserker66
approved these changes
Oct 20, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OoT has randomized shop locations which are considered events, but are only filled during prefill. Since plando runs first, the consequence is that plando could place items into these locations. Usually this isn't a problem, but
early_itemsacquired all locations including unfilled events, which could cause items to be placed on event locations. This adds multiple safeguards against this occurring.