Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokémon R/B: Door Shuffle fixes #2314

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Oct 15, 2023

What is this fixing or adding?

  • Fixes an issue where collecting an item to check whether it adds reachable entrances during entrance shuffle causes a sweep for events with that item which can collect items into the state that remain collected, which can cause regions to appear reachable during door shuffle that shouldn't. This affects Full and Insanity door shuffles.
  • Fixes an issue where placing Cascade Badge in Celadon Gym is prevented only when badges_needed_for_hm_moves is on but not when it is set to extra. Affects all door shuffle options.
  • Fixes the Celadon Gym gym leader being in the Celadon Gym region instead of Celadon Gym-C (The central area of the gym which requires Cut). This could erroneously put passing the Route 3 guard in logic.
  • Adds the Route 23 door for the exit from Victory Road to the list of unreachable outdoor entrances so that it ensures it is connected to before running out of doors (the Pokémon League door is always a Pokémon Center and thus always a dead end).

How was this tested?

Generating with Figment's test yaml and seed number as well as a few random gens

Copy link
Collaborator

@t3hf1gm3nt t3hf1gm3nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested using the yaml submitted with the initial bug report and seems to have fixed the issue i had ran into. ran several test gens and no longer running into the error

@ScootyPuffJr1 ScootyPuffJr1 added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 17, 2023
@Berserker66 Berserker66 merged commit 13b68ec into ArchipelagoMW:main Oct 17, 2023
12 checks passed
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
* Door shuffle fixes

* Add Rt 23's Victory Road exit door to list of unreachable outdoor entrances
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
* Door shuffle fixes

* Add Rt 23's Victory Road exit door to list of unreachable outdoor entrances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants