WebHost: offer combined yaml file on /check if successful #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +31,15 @@ def check(): | |||
| flash(options) | |||
| else: | |||
| results, _ = roll_options(options) | |||
| return render_template("checkResult.html", results=results) | |||
| if len(options) > 1: | |||
There was a problem hiding this comment.
shouldn't this be len(files) to not offer download for a single yaml file with --- already in it?
There was a problem hiding this comment.
I tried uploading a combined yaml and it doesn't offer a download. options is file -> file content and is not yet yaml parsed.
There was a problem hiding this comment.
oh, i see. options is actually individual files, not individual options. somehow i didn't expect that
ScootyPuffJr1
added
is: enhancement
black-sliver
approved these changes
Oct 21, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
adds a combined yaml file as download to a succesful /check run with multiple files
bonus inclusions:
fixes many guides hitting a redirect
fixes import * in check.py
How was this tested?
on Vivaldi
If this makes graphical changes, please attach screenshots.