Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OoT: create and copy less useless data state #2379

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Made a 300 world Factorio gen take 132 seconds instead of 160 seconds.

How was this tested?

With 300 Factorio worlds

If this makes graphical changes, please attach screenshots.

Copy link
Collaborator

@espeon65536 espeon65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked an oot generation, works fine

@ScootyPuffJr1 ScootyPuffJr1 added the is: refactor/cleanup Improvements to code/output readability or organizization. label Oct 27, 2023
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this is doing, but it looks good and espeon approved

@Berserker66 Berserker66 merged commit 20dd478 into main Oct 28, 2023
21 checks passed
@Berserker66 Berserker66 deleted the oot_less_state_data branch October 28, 2023 01:13
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants