Noita: Fix rare item fill failure for single-player games

[ScipioWright]

What is this fixing or adding?

Shops in Noita have some items that are not allowed to be there -- namely, physics items, since you can usually break them.
Makes it so it checks whether enough shop-allowed items are in the itempool already, and makes more if not.

Eventually, this fix will be reverted in favor of making the physics items in the shop not have physics. That will have to wait for the current Noita beta to get pushed live, though.

How was this tested?

Several generations with one and multiple Noita yamls with random settings.

If this makes graphical changes, please attach screenshots.

N/A

[heinermann]

Maybe a little bit more convoluted than it needs to be. We can pass the dict to create_random_items instead of separate count values. Something like

# 39 is the number of shop-valid items we need to guarantee
if len(itempool) < 39:
    itempool += create_random_items(multiworld, player, shop_only_filler_weights, 39 - len(itempool))
itempool += create_random_items(multiworld, player, item_filler_weights, locations_to_fill - len(itempool))

[heinermann]

filler_weights below can then be defined as I think something like (assuming the weights will be the same)

filler_weights: Dict[str, int] = {
    **shop_only_filler_weights,
    "Gold (200)": 15,
    ....

[ScipioWright]

Doing it this way I'm getting constant failures with a minimal items solo yaml. The main issue: I don't think AP is placing the items correctly. I'm loading in exactly 7 perks, 32 hearts, and 7 Gold (200)s. The only way for it to work is if it places the perks + hearts in the 39 shop slots, and the 7 Gold (200)s in the 7 spell refresher spots. It is not doing this most of the time.

[ScipioWright]

Of note, the number of Golds it fails to place is not consistent. Most of the time, it fails to place 2 of them. Sometimes, 3. Sometimes, 1. Rarely, it succeeds.

[ScipioWright]

Alright, changed it so that we're doing a lot of manual fill if we have only one player. It's messy and dumb, but it passes the tests.