OoT Time Optimization #2401
Merged
OoT Time Optimization #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn't need this?
Split itempool into main and prefill pools Modify only prefill pool Faster state creation
I hope???
Eventually we want to remove the full recache and just delete them from the cache directly, but I will save that for after ArchipelagoMW#2366
and not the other way around.
Prevents new entrance cache from breaking
Berserker66
reviewed
Oct 29, 2023
| @@ -1271,9 +1301,17 @@ def get_region(self, region_name): | |||
| self._regions_cache[region_name] = ret | |||
| return ret | |||
|
|
|||
| @functools.cache | |||
| def get_entrances(self): | |||
There was a problem hiding this comment.
self.multiworld.get_entrances(self.player) gives you all entrances for that player, already cached and already filtered.
Berserker66
reviewed
Oct 29, 2023
worlds/oot/__init__.py
Outdated
|
|
||
| def get_shuffled_entrances(self, type=None, only_primary=False): | ||
| return [entrance for entrance in self.get_shufflable_entrances(type=type, only_primary=only_primary) if | ||
| entrance.shuffled] | ||
|
|
||
| @functools.cache |
There was a problem hiding this comment.
functools.cache is not available on Python 3.8
goodbye event cache
Berserker66
approved these changes
Oct 30, 2023
Berserker66
approved these changes
Oct 30, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
- Entrance randomizer no longer grows with multiworld - Improved ER success rate again by prioritizing Temple of Time even more - Prefill is faster, has slightly reduced failure rate when map/compass are in dungeon but previous items in any_dungeon (which consumed all available locations), no longer removes items from the main itempool; itemlinked prefill items removed to accomodate improvements - Now triggers only one recache after `generate_basic` instead of one per oot world - Avoids recaches during `create_regions` - All ER temp entrances have unique names (so the entrance cache does not break)
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
- Entrance randomizer no longer grows with multiworld - Improved ER success rate again by prioritizing Temple of Time even more - Prefill is faster, has slightly reduced failure rate when map/compass are in dungeon but previous items in any_dungeon (which consumed all available locations), no longer removes items from the main itempool; itemlinked prefill items removed to accomodate improvements - Now triggers only one recache after `generate_basic` instead of one per oot world - Avoids recaches during `create_regions` - All ER temp entrances have unique names (so the entrance cache does not break)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_basicinstead of one per oot worldcreate_regions