Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: check that location address is unique per player #2429

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Core: check that location address is unique per player #2429

merged 1 commit into from
Nov 15, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

in debug mode, checks that location address is unique per player

How was this tested?

just with a run of LttP so far

If this makes graphical changes, please attach screenshots.

@ScootyPuffJr1 ScootyPuffJr1 added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels Nov 6, 2023
black-sliver
black-sliver approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine. However maybe we should also add this check to the world test base so we catch it earlier

@Berserker66 Berserker66 merged commit 829c664 into main Nov 15, 2023
21 checks passed
@Berserker66 Berserker66 deleted the core_check_duplicate_location_address branch November 15, 2023 19:50
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@Berserker66 @Jouramie
Core: check that location address is unique per player (ArchipelagoMW…
9f6e80b 
…#2429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Berserker66 @black-sliver @ScootyPuffJr1