Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: relax typing hints on has_all and has_any #2462

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

https://discord.com/channels/731205301247803413/731214280439103580/1174096630425862256
also threw in some micro optimizations

How was this tested?

unittests

If this makes graphical changes, please attach screenshots.

@Jarno458 Jarno458 added is: refactor/cleanup Improvements to code/output readability or organizization. affects: core Issues/PRs that touch core and may need additional validation. labels Nov 14, 2023
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Berserker66 Berserker66 merged commit 8ce073e into main Nov 15, 2023
21 checks passed
@Berserker66 Berserker66 deleted the core_state_typing_relax branch November 15, 2023 05:53
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants