WebHost: Some refactors and additional checks when uploading files. #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: bug/fix
Berserker66
reviewed
Dec 3, 2023
| allowed_generation_extensions = (".archipelago", ".zip") | ||
|
|
||
|
|
||
| def allowed_options(filename: str) -> bool: |
There was a problem hiding this comment.
I can't place it, but these feel wrongly named.
Maybe "is_allowed_options_filename"? Sounds a bit overly verbose though.
There was a problem hiding this comment.
Naming was honestly the hardest part of this PR.
Berserker66
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Does some refactoring and adds additional checks for files that are uploaded to the WebHost.
Additional checks include:
.zipfiles are proper zip files (e.g. not renamed.rar/.7zfiles)..).Also tweaks some of the error messages to be a bit more clear and list all known valid option files if files are submitted without them.
How was this tested?
__MACOSXfolder..zipfile..zipto/generateand options to/hostGame..png..7zfile renamed as a.zipfileAll of these would have given unclear (or thrown 500) error on current, but do not with these changes.
This one still succeeds. :P
If this makes graphical changes, please attach screenshots.
Host Game
Generate Game
