SA2B: Fix KeyError on Unexpected Characters in Slot Names #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysintreble
added
is: bug/fix
Berserker66
reviewed
Dec 7, 2023
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>
Berserker66
approved these changes
Dec 8, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…oMW#2571) There were no safeguards on characters being used as keys into a conversion dict. Now there are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
There were no safeguards on characters being used as keys into a conversion dict. Now there are.
How was this tested?
Ran generations with known and expected failure states; names generated as expected.
If this makes graphical changes, please attach screenshots.