Core: faster prog balance #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magnemania
pushed a commit
to Magnemania/Archipelago
that referenced
this pull request
Jan 3, 2024
* Core: rename world to multiworld in balance_multiworld_progression * Core: small optimization to progression balance speed
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* Core: rename world to multiworld in balance_multiworld_progression * Core: small optimization to progression balance speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
remove a variable and its updates, skipping instructions
pops by index instead of equality, which is quite a bit faster in itself, though not that much in the context of the whole function
How was this tested?
just a few gens that hit that code path
If this makes graphical changes, please attach screenshots.