Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Junk hints for Shivers, Mystic Quest and Heretic #2592

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

NewSoupVi
Copy link
Member

It's another one of these yay

Also modified one joke hint because it was a bit too close to looking like an actual error.

@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Dec 11, 2023
Copy link
Contributor

@ReverM ReverM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@black-sliver
Copy link
Member

Are we sure we want to have "I suck" in hints? I'd be fine with it, but just double checking.

@NewSoupVi
Copy link
Member Author

Is that aimed at me? If so, I don't think it's bad

@black-sliver
Copy link
Member

It was aimed at everyone subscribed to the PR (you, medic and rever)

@Exempt-Medic
Copy link
Collaborator

The phrase seems good to me. It fits the general joking tone of the hints and the ocassionally meta / fourth-wall-beaking style of both the game and the other hints

@black-sliver black-sliver merged commit 57cb971 into ArchipelagoMW:main Jan 31, 2024
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants