Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingo: Remove colors from Bearer SIXes #2677

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

hatkirby
Copy link
Collaborator

@hatkirby hatkirby commented Jan 5, 2024

What is this fixing or adding?

The SIX panels in The Bearer are white, so they should not be marked as being red and yellow like they currently are. This is not urgent, because the client and generator are consistent about this incorrect logic, but it would be good to get this fixed for the future since it is unintuitive.

How was this tested?

Ran the validate config script and pytest.

If this makes graphical changes, please attach screenshots.

Copy link
Contributor

@ReverM ReverM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are pretty minor but do what is expected - LGTM

@ScipioWright ScipioWright added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jan 9, 2024
@Berserker66 Berserker66 merged commit d390d2e into ArchipelagoMW:main Jan 16, 2024
7 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants