Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingo: Make The Colorful optionally progressive #2711

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

hatkirby
Copy link
Collaborator

What is this fixing or adding?

The Colorful is a linear set of 10 rooms with doors between them. It can be entered from the front or the back, but not in the middle. On complex door shuffle, each door is opened by a separate item, which often leads to receiving a lot of doors in the middle of The Colorful that cannot be accessed until later.

This change adds an option to convert The Colorful into a progressive item, similar to the option that does this for the Orange Tower. This removes the individual door items and adds ten Progressive Colorful items, which open the doors one-by-one from the front.

How was this tested?

Test generations, and playing in the future branch client.

If this makes graphical changes, please attach screenshots.

@@ -70,6 +74,8 @@ def load_item_data():
if room_name in PROGRESSION_BY_ROOM and door_name in PROGRESSION_BY_ROOM[room_name]:
if room_name == "Orange Tower":
door_mode = "orange tower"
elif room_name == "The Colorful":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to look a lil goofy, but I get it, not a real issue

Comment on lines +86 to +87
if (room_name == "Orange Tower" and not world.options.progressive_orange_tower)\
or (room_name == "The Colorful" and not world.options.progressive_colorful):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you get away with it but if you add like, a third and fourth thing, I'll ask you to find a way to format it differently

Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say, looks good

The change also makes sense and is welcome, I personally would've just made it default tbh (see: Progressive Art Gallery), but I can see good reasons not to

@ReverM
Copy link
Contributor

ReverM commented Jan 14, 2024

Not much to say, looks good

The change also makes sense and is welcome, I personally would've just made it default tbh (see: Progressive Art Gallery), but I can see good reasons not to

You can access the colorful from behind via roof so having it be non progressive can be a bit more interesting

@hatkirby
Copy link
Collaborator Author

Fwiw it does default on.

@@ -21,6 +21,13 @@ class ProgressiveOrangeTower(DefaultOnToggle):
display_name = "Progressive Orange Tower"


class ProgressiveColorful(DefaultOnToggle):
"""When "Shuffle Doors" is on "complex", this setting governs the manner in which The Colorful opens up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting needs to be changed to option (same for ProgressiveOrangeTower)

@NewSoupVi
Copy link
Member

NewSoupVi commented Jan 14, 2024

Not much to say, looks good
The change also makes sense and is welcome, I personally would've just made it default tbh (see: Progressive Art Gallery), but I can see good reasons not to

You can access the colorful from behind via roof so having it be non progressive can be a bit more interesting

And you could access the Art Gallery from behind if the exit were not part of the progressive chain, that's what I meant by that comparison. "Progressive Art Gallery" including the Art Gallery Exit technically also gets rid of an "interesting" backwards access

@Berserker66 Berserker66 merged commit c6896c6 into ArchipelagoMW:main Jan 16, 2024
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants