OOT: Adjust the Logic Trick Keys to be an ordered object #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few hours ago, I tested whether the client would run successfully on macOS (Send/Receive items, load maps, download maps, etc.). After the successful testing, I thought adding some documentation would be nice for those who want to play Archipelago on a macOS system.
Adding SC2 macOS instructions
Turns out you don't need sudo to do the download_data, oops.
Added an alternate option to simply terminal navigation
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
Bicoloursnake
changed the title
|
Looks good to me, although it would be nice if you cleaned up the commit history of this branch |
|
Sorry about the commit history. Is there a resource you can point me to for cleaning up commit history? I haven't had much luck using Github's sync fork feature to do it, and I'm not quite sure where else to look. |
Berserker66
approved these changes
Jan 18, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey wait a minute, this isn't (directly) a documentation PR, who let me touch actual code?
What is this fixing or adding?
In current main, the logic tricks in OOT end up as
frozensetobject, so they don't maintain the desired order. This PR instead has them as atuple, in order to maintain the immutability of frozenset, while keeping the desired order of objectsHow was this tested?
Several local generations and spot checking the webhost, in addition to the standard unit tests.
If this makes graphical changes, please attach screenshots.
Before:
After:
