Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingo: Split up Color Hunt and Champion's Rest #2745

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

hatkirby
Copy link
Collaborator

What is this fixing or adding?

"Color Hunt" and "Champion's Rest" are now two separate rooms. The resulting logic is similar to before, with the exception that the painting inside of Champion's Rest is now a possible exit, meaning that the room can be accessed and the panels solved without accessing Color Hunt.

How was this tested?

validate_config.rb, pytest, and a test playthrough.

If this makes graphical changes, please attach screenshots.

@hatkirby
Copy link
Collaborator Author

Pre-release client that can be used to test this change: lingo_archipelago_future_2745.zip

@Jarno458 Jarno458 added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jan 22, 2024
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially just shuffling some things around to create an entrance, so not too much to break. Test gens worked fine. I'd say to increment the data version, but I remember some chatter about "just let those have issues to get those world devs to update to not rely on data version", so probably don't do that.

@PoryGone PoryGone added waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 10, 2024
@Berserker66 Berserker66 merged commit 2167db5 into ArchipelagoMW:main Feb 14, 2024
12 checks passed
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 14, 2024
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants